search

agilgur5 / react-signature-canvas

A React wrapper component around signature_pad (in < 150 LoC). Unopinionated and heavily updated fork of react-signature-pad
https://agilgur5.github.io/react-signature-canvas/
Other
546 stars 119 forks source link

Add compatilibity to React 16 without warnings #14

Closed lopis closed 6 years ago

lopis commented 7 years ago

react-signature-canvas seems to work flawlessly with React 16 and React DOM 16 but the package.json does not reflect that, cause warnings to be thrown when installing dependencies.

warning "react-signature-canvas@0.1.7" has incorrect peer dependency "react@^0.14.0 || ^15.0.0".
warning "react-signature-canvas@0.1.7" has incorrect peer dependency "react-dom@^0.14.0 || ^15.0.0".
hollygirouard commented 6 years ago

This would be awesome if you could merge it! Thanks in advance!

agilgur5 commented 6 years ago

Released as v0.2.3 as 8fd954ebfad1666f7b4b38afe65701ff49ea17ae and as v0.1.9 as 1e804d8db9a3badf38dd9ef9091e756f7f30097a . Thanks for the repeated contributions @lopis!

@hollyewhite per lopis's opening comment this looks like it only threw a warning, so it should not have been a blocker in adoption of React 16