search

agilgur5 / react-signature-canvas

A React wrapper component around signature_pad (in < 150 LoC). Unopinionated and heavily updated fork of react-signature-pad
https://agilgur5.github.io/react-signature-canvas/
Other
528 stars 115 forks source link

React 17 support in peerDeps range #58

Closed mihkeleidast closed 2 years ago

mihkeleidast commented 3 years ago

This module does not currently allow React 17 in it's peerDependency range. Requesting that this would be allowed.

agilgur5 commented 3 years ago

Yea was planning on making that change soon. Should probably work fine with React 17 since it only changes event capture and react-signature-canvas and signature_pad don't rely on React's event capture.

I'll have to update the devDep and make sure tests pass first. Might get to it in the coming week as I've been looking to get back to this library and make some merges I put off.

In any case, it's just a warning, so it should not be a blocker.

mihkeleidast commented 3 years ago

Would you accept a PR if everything works? I like to strictly follow peerDependency ranges so this may block our upgrade soon.

ctrlaltdylan commented 3 years ago

Would also be open to lend a hand if needed

JenRuey commented 3 years ago

Hi, would like to know when the solution will be released. Knowing this will come together with other important fixes but just want to confirm the date.

mihkeleidast commented 3 years ago

Now that npm v7 has been released, this is becoming more of a blocker to upgrading. npm@7 throws an error if peerDeps cannot be resolved correctly.

durgeshrkumari commented 2 years ago

Are we adding support for React 17? I tried to upgrade the react in a fork, but getting some issues running the test after upgrading enzyme.

ashen780 commented 2 years ago

any quick workaround to make this work on react 17? edit: found this compatible version https://www.npmjs.com/package/react-signature-canvas-react17-compatible

luke9216 commented 2 years ago

@agilgur5 can we get an update on this? Cheers

filkalny-thimble commented 2 years ago

@agilgur5 It would be nice to have this ASAP

luke9216 commented 2 years ago

Hi all. I have created an npm package as a workaround for the React 17 issue https://www.npmjs.com/package/react-signature-drawing. This has a direct dependency on this project. This should be used until agilgur5 is back

jmalbite commented 2 years ago

Hi @luke9216 how to use your package?

Sean-Y-X commented 2 years ago

Any plan when React 17 support will be added?

agilgur5 commented 2 years ago

Released in v1.0.5