search

agiliq / django-graphos

Django charting made *really* easy.
http://agiliq.com/demo/graphos
BSD 2-Clause "Simplified" License
442 stars 97 forks source link

make data sources responsible for json conversion #14

Closed anentropic closed 8 years ago

anentropic commented 10 years ago

eg Django models need to use DjangoJSONEncoder

Only the data source knows how to correctly serialise to JSON for its objects, therefore the serialisation should happen in the data sources instead of the renderers

shabda commented 10 years ago

@anentropic : Travis can't find any of your templates. https://travis-ci.org/agiliq/django-graphos/jobs/15629566

I'll try taking a look this weekend on why this is happening.

anentropic commented 10 years ago

Sorry, looks like I maybe forgot to commit them, if so they're on my other computer and I'm away for a few weeks over Christmas. Looks like the tests need updating too. I can look into it when I get back

akshar-raaj commented 10 years ago

@anentropic Can you look into it and update it?

anentropic commented 10 years ago

the issue with templates is on my other PR #15

anentropic commented 10 years ago

fixed, sorry it took so long :)