search

agiorguk / gemini-schematron

The Schematron files to support GEMINI 2.3 validation
0 stars 1 forks source link

GEMINI 2.3 fixes #5

Open archaeogeek opened 3 years ago

archaeogeek commented 3 years ago

Issue by nmtoken Mon Nov 2 17:27:37 2020 Originally opened as https://github.com/AGIuk/Schematron/pull/4

Proposed changes to GEMINI 2.3.n schematron

nmtoken included the following code: https://github.com/AGIuk/Schematron/pull/4/commits

archaeogeek commented 3 years ago

Comment by archaeogeek Tue Nov 3 11:21:31 2020

Any chance of a diff between this and the previous version?

archaeogeek commented 3 years ago

Comment by nmtoken Tue Nov 3 16:27:51 2020

Added a diff between the files, I uploaded a new file rather than change the existing one for two reasons, first is that the original file has a version number attached, and second related to that is that we may want a candidate release for all new proposed changes. These changes should be for consideration/testing at the moment, not latest GEMINI.

archaeogeek commented 3 years ago

Comment by PeterParslow Thu Feb 4 16:27:09 2021

I challenge the test that triggers MI-18a (line 33 in the diff)

test="($hierarchyLevelCLValue = 'dataset' or $hierarchyLevelCLValue = 'series') and ($srES > 0 and $srES > 0)

surely one of the two $srES should be $srD?

And you would then want to fix the report that it gives (line 35 in the diff)

archaeogeek commented 3 years ago

Comment by nmtoken Wed Feb 10 10:24:53 2021

This is now out of date.