search

agiorguk / gemini

Resources relating to the UK Gemini metadata profile
5 stars 3 forks source link

Peter parslow patch 1 #112

Closed PeterParslow closed 8 months ago

PeterParslow commented 9 months ago

Change the "return to home page" links to point to the new "introduction" text, which partly resolves https://github.com/agiorguk/gemini/issues/24 and https://github.com/agiorguk/gemini/issues/31

The other action would be to get AGI to redirect to the new page rather than the current "home page".

Remove the Word & HTML files from 'pending' that relate to fixing this issue in the old publication route.

PeterParslow commented 9 months ago

Also deleted the "pending" files (& folder) because all those changes have been implemented during migration.

archaeogeek commented 8 months ago

Reviewed and approved by @archaeogeek

PeterParslow commented 8 months ago

Jo, I'm a bit confused by this message:

"Closed with unmerged commits" - I will try to find what commits I made to the PeterParslow-patch 1 branch that somehow didn't get merged. I also thought I'd asked for it to be merged into "dev" as per agreed process, but here is says its merged into "main". The "return to home page" links haven't changed in the "main" branch. But neither can I see the changes in the dev branch.

Have you closed it without merging this PR at all, @archaeogeek ?

archaeogeek commented 8 months ago

@PeterParslow I had assumed that it was because you had a second PR as well, but I'm not sure, so I will reopen and have a dig.

archaeogeek commented 8 months ago

Can you try editing this PR (edit button at the top, by the title) and changing the base from main to dev?

PeterParslow commented 8 months ago

Can you try editing this PR (edit button at the top, by the title) and changing the base from main to dev?

Done; it gave me a warning, but seemed OK to change.

PeterParslow commented 8 months ago

@PeterParslow I had assumed that it was because you had a second PR as well, but I'm not sure, so I will reopen and have a dig.

I think Patch 1 covered the issues that had already been sent to AGI. Patch 2 includes the ones that were in the "pending release" column, but where the HTML hadn't been sent to AGI.