agittins / bermuda

Bermuda Bluetooth/BLE Triangulation / Trilateration for HomeAssistant
MIT License
422 stars 10 forks source link

Version is not displayed in Integration Page #241

Open fwmarcel opened 2 months ago

fwmarcel commented 2 months ago

Version of the custom_component

v0.6.7

Describe the bug

The version is not displayed on the integration page. The version should be in the manifest.json in order to be displayed correctly.

{
  "domain": "bermuda",
  "name": "Bermuda BLE Trilateration",
  "bluetooth": [
    {
      "connectable": false,
      "manufacturer_id": 76
    }
  ],
  "codeowners": ["@agittins"],
  "config_flow": true,
  "dependencies": ["bluetooth_adapters", "device_tracker"],
  "documentation": "https://github.com/agittins/bermuda",
  "integration_type": "device",
  "iot_class": "calculated",
  "issue_tracker": "https://github.com/agittins/bermuda/issues",
  "requirements": [],
  "version": "0.0.0"
}
Screenshot 2024-07-14 at 12 40 57
agittins commented 2 months ago

Howdy, and thanks for bringing this up.

It's something I did the rounds on long ago and couldn't find a solution I was OK with. In particular, it seemed to me at the time that HACS was pulling from the repo rather than the zipped release file, so was showing 0.0.0 even though the released files had versions in them. I have a personal conviction that the files in the repository heads should not have version numbers in them, and I couldn't find a way around it at the time (I remember I looked at the Grocy integration and wasn't happy with adopting however it was they were doing it).

However, I've just taken a look at the Spook integration (since I figured if there's a way, Franck would know) and it looks like it handles everything just fine, so I'll take a dig through his integration's config and see what it is I'm doing wrong.

agittins commented 2 months ago

A win! I have just released v0.6.8 and it now shows the version number correctly! :D Thanks for the nudge!

agittins commented 1 month ago

Sigh. So the problem with switching to zipped releases is that then the main download doesn't work, with a 404 (because there's no zip file maintained for the main branch).

I think I'm switching to a different model, of creating draft releases (rc / release-candidates) instead. I'm still not entirely happy with it but it might be the only/best way that fits all my personal requirements. These are:

I'm reopening this until I'm happy with it.