make tests work without GTK

agl / pond

Pond

BSD 3-Clause "New" or "Revised" License

912 stars 110 forks source link

make tests work without GTK #165

Closed bnagy closed 9 years ago

bnagy commented 9 years ago

Turns out there wasn't much to do. I skipped a step in the test logic when there's no erasure storage and added a build tag so you can build the abstract gui without trying to build gtk. Added a new flag nogtk, stubbed out the GTKUI interface so the mains don't need to be modified.

bens-MacBook-Pro:client ben$ go test -tags nogtk
PASS
ok      github.com/bnagy/pond/client    46.853s

agl commented 9 years ago

Thanks!

burdges commented 9 years ago

I'm curious why nogtk is added as a separate build tag, and file, rather than adding this under the existing nogui tag? Just more convenient for the android effort organize by @grugq ? Thanks.

bnagy commented 9 years ago

Because I still wanted the abstract GUI to build, so I could run the rest of the tests unmodified.