agl / pond

Pond
BSD 3-Clause "New" or "Revised" License
911 stars 109 forks source link

Race condition in PANDA #170

Closed burdges closed 9 years ago

burdges commented 9 years ago

There are odd race conditions when users are trying to connect using PANDA, seemingly repeatedly miss-typing the shared secret, and deleting the spurious contacts before the other exchange takes place.

I've managed to have a two contacts for the same person both showing as paired correctly on my end :

Is there maybe a race condition between PANDA and the generation update?

burdges commented 9 years ago

I reproduced the DELIVERY_SIGNATURE_INVALID with another person by deleting a contact in the middle of a PANDA key exchange, but it "healed" after one failed attempt. I'll need to read the code to figure out what's going on here.

burdges commented 9 years ago

I'll close this since it's likely whatever happened here : https://github.com/agl/pond/issues/135#issuecomment-82386725