client_test could be more generic

agl / pond

Pond

BSD 3-Clause "New" or "Revised" License

911 stars 109 forks source link

client_test could be more generic #204

Open infinity0 opened 8 years ago

infinity0 commented 8 years ago

I'm building pond without the GUI (-tags nogui) but then client_test fails to build with undefined: FileOpen. It seems very specific to the GUI, maybe some parts could be applied to the CLI too?

burdges commented 8 years ago

A partial fix was merged here : https://github.com/agl/pond/pull/165

infinity0 commented 8 years ago

Ah, I just need to set nogtk instead of nogui, looks like it works. But then the built client thinks that haveGUI = true; I'll send in a patch.

burdges commented 8 years ago

Any client actually built for usage only from the command command line should still use nogui. The abstract GUI built by nogtk is needed for testing, but not for CLI operation.

infinity0 commented 8 years ago

But it's quite annoying to have to build it twice, once for running and once for tests. That's not a normal workflow for doing builds.