search

agl / pond

Pond
BSD 3-Clause "New" or "Revised" License
912 stars 110 forks source link

Added reply quoting to the GUI. #85

Closed burdges closed 10 years ago

burdges commented 10 years ago

Ideally this should quote only the selected text if any text is selected in the message viewer when the user presses reply. At least that's how my email client works.

I assume Go initializes the two local variables I eliminated to zero, but I thought it looked cleaner to initialize them explicitly and and set them if inReplyTo is set.

burdges commented 10 years ago

Should this sort of pull request go into a separate branch?

agl commented 10 years ago

Crap, sorry. No - it's just my failures at handling email. Have starred - hopefully will look at it this weekend.

burdges commented 10 years ago

No worries. :)

There are projects on github that have views, rules, etc. on what sort of changes contributors should keep in a named branch, presumably it makes merging easier in some situations.

On 28 Mar 2014, at 14:51, Adam Langley notifications@github.com wrote:

Crap, sorry. No - it's just my failures at handling email. Have starred - hopefully will look at it this weekend.

agl commented 10 years ago

Done (even if GitHub isn't picking up the change for some reason). Sorry that "this weekend" took about three months!