search

agl / xmpp-client

An XMPP client with OTR support
BSD 3-Clause "New" or "Revised" License
365 stars 71 forks source link

Added functionality to set resource. #120

Closed 0x747972 closed 8 years ago

0x747972 commented 8 years ago

You can set the resource of the client now.

agl commented 8 years ago

Is setting the resource sufficiently common that it warrants a question during setup, or is it best left as an option in the config file for those who need it enough to search for it?

If the former, can the prompt be made more helpful without making it too long? (I.e. why would I want to set a resource? What values are reasonable?)

0x747972 commented 8 years ago

It's rather common, I think.

Maybe one could put an example, like Set resource? eg. "work" (Enter to skip): or something to that effect.

agl commented 8 years ago

Committed as abbf9020393e8caae3e8996a16ce48446e31cf0e

agl commented 8 years ago

I had to rebase your change to squash it into one commit, so GitHub won't automatically notice that it's been committed. I changed the prompt wording a little but that's all. Thanks.

0x747972 commented 8 years ago

Ok, thanks for accepting the pull request.