search

aglago / smaglago

Building my portfolio website as a growing full stack engineer
https://portfolio2023-ten-rho.vercel.app
3 stars 0 forks source link

cool portfolio site, horizontal scroll issue on mobile #12

Open lpmi-13 opened 7 months ago

lpmi-13 commented 7 months ago

Love the style of this portfolio. I did notice on mobile that the horizontal scroll extends past the content.

I'm on android using mobile Firefox, if that helps reproduce at all.

I was thinking of raising a PR to fix it, but saw you're not interested in contributions, so thought I'd raise an issue instead.

Screenshot_20240410_091411_Firefox

aglago commented 7 months ago

Oh thanks 🙏🏽 I'll check it out later today. But what is giving the impression that I'm not interested in contributions please?

aglago commented 7 months ago

I saw this problem earlier and thought I had fixed it. It was caused by nested CSS. And I removed all nestings. Can you try updating your browser and try it again for me to know whether it still persists? 🙏🏽

lpmi-13 commented 7 months ago

Oh thanks 🙏🏽 I'll check it out later today. But what is giving the impression that I'm not interested in contributions please?

It was the part about not accepting contributions from others here:

https://github.com/aglago/smaglago?tab=readme-ov-file#contributing

I'd happily submit a PR for anything else in the future though if you'd prefer that instead of an issue.

lpmi-13 commented 7 months ago

I saw this problem earlier and thought I had fixed it. It was caused by nested CSS. And I removed all nestings. Can you try updating your browser and try it again for me to know whether it still persists? 🙏🏽

Looks like it's still an issue in Firefox (I cleared the cache and even tried in a private browsing window).

Screenshot_20240410_114309_Firefox

Looks good in mobile chrome though 🎉 Screenshot_20240410_114551_Chrome

If I had to guess I'd saw its the width of the header that's causing issues, but just on my phone at the moment so can't do a thorough investigation.

aglago commented 7 months ago

Oh thanks 🙏🏽 I'll check it out later today. But what is giving the impression that I'm not interested in contributions please?

It was the part about not accepting contributions from others here:

https://github.com/aglago/smaglago?tab=readme-ov-file#contributing

I'd happily submit a PR for anything else in the future though if you'd prefer that instead of an issue.

Oh alright, seen.

aglago commented 7 months ago

I saw this problem earlier and thought I had fixed it. It was caused by nested CSS. And I removed all nestings. Can you try updating your browser and try it again for me to know whether it still persists? 🙏🏽

Looks like it's still an issue in Firefox (I cleared the cache and even tried in a private browsing window).

Screenshot_20240410_114309_Firefox

Looks good in mobile 🎉 Screenshot_20240410_114551_Chrome

If I had to guess I'd saw its the width of the header that's causing issues, but just on my phone at the moment so can't do a thorough investigation.

I will work on it in my free time. Thank you very much for your time. I really appreciate it. Where can I connect with you? What's your X username?

lpmi-13 commented 7 months ago

I'm @BaronVonLeskis over there 👋