search

agmmnn / tauri-controls

🚥 Native-looking window controls for Tauri 2. React, Solid, Vue, Svelte+Tailwind.
https://npmjs.com/package/tauri-controls
MIT License
581 stars 21 forks source link

move all Tauri to devDeps, let user install #20

Closed jbolda closed 5 months ago

jbolda commented 5 months ago

Motivation

This closes #19. I am recommending removing all Tauri related deps from the dependencies list. The instructions already note to install these, and putting them in peerDependencies or dependencies may end up installing multiple versions of these packages. As v2 is in alpha and these packages need to stay in sync with the cargo installed version, it will likely be the most stable allowing the user to install.

Approach

Moved all deps to devDeps so they are installed for the example apps. Also bumped the versions in the Cargo.toml as well. I actually played around with and fixed this live on my YouTube stream. If interested in the deeper thoughts behind this, I laid them all out there.

❤️ Thanks again for your work on this!

agmmnn commented 5 months ago

Thank you so much. I haven't had much time for github lately, so this was helpful.

It's exciting to watch my own repo on Youtube. :)