search

agnat / node_mdns

mdns/zeroconf/bonjour service discovery add-on for node.js
http://agnat.github.com/node_mdns
MIT License
868 stars 145 forks source link

Add option to disable looking up interface names #245

Closed ErwinSteffens closed 3 years ago

ErwinSteffens commented 3 years ago

Add new option to disable looking up the interface name on an event.

Not sure, but could it be that the assertions are not working correctly?

See https://github.com/agnat/node_mdns/issues/244 for context.

agnat commented 3 years ago

Hehe... except the test doesn't work. With the new tests the test suite exits silently after only 4 checks on mac os. Not sure what's going on. Could you look into it? 🤔

ErwinSteffens commented 3 years ago

Yeah, already mentioned it above here:

Not sure, but could it be that the assertions are not working correctly?

I thought it was not something I had introduced. Stupid mistake. Fix is in #246.

agnat commented 3 years ago

Yeah, already mentioned it above here

Not sure, but could it be that the assertions are not working correctly?

Right. Yes. That is very well possible. Unfortunately, both the tests and the documentation are mostly spit and glue. It's embarrassing...