search

agnelvishal / Condense.press

GNU General Public License v3.0
12 stars 25 forks source link

Iframes to ajax #22

Open intelliapps opened 5 years ago

intelliapps commented 5 years ago

Updated to replace iframe in index.php with content loaded from articles.php (was db.php) via an ajax request.

NB I noticed that the value of the 'site' select input doesn't seem to be used presently to retrieve data but have passed it's value into articles.php anyway.

agnelvishal commented 5 years ago

I wanted ajax request to be sent to rest api instead of article.php or db.php. This will eliminate the need to expose database credentials.

intelliapps commented 5 years ago

I would be happy to have a go at that if you raise it as another issue. I absolutely agree that articles.php needs work (I usually work with the Symfony framework which has a very well defined structure) but I believe I have done exactly what was requested in the issue I was addressing. This was already a fair amount of work and migrating articles.php into the rest API will be a fair amount also.

intelliapps commented 5 years ago

If possible, you should exclude the third party jquery library files from the automated code reviews. Also, for production jquery-3.3.1.min.js should be loaded in place of jquery-3.3.1.js

agnelvishal commented 5 years ago

Rest api has been updated with database access