agners / micropython-scd30

MicroPython I2C driver for SCD30 CO2 sensor module
MIT License
24 stars 15 forks source link

Use wrapper to paper over the differences between I2C APIs. #2

Closed DanielO closed 4 years ago

DanielO commented 4 years ago

I redid my last version as it seem there are platform differences between (at least) ESP32 and pyboard with v1.11.

agners commented 4 years ago

Sorry, this somehow slippt through.

I did run some nightly build back then, and 1.12 these days. I think those differences are gone today? Do you think its still worth merging this?

DanielO commented 4 years ago

No problem - I haven't checked myself but if you think the interfaces are harmonised now then I don't see any point in cluttering up your code with compat shims.