search

agnivade / levenshtein

Go implementation to calculate Levenshtein Distance.
MIT License
358 stars 28 forks source link

return error? #1

Closed jpillora closed 9 years ago

jpillora commented 9 years ago

Nice library, though is there a special reason why you're returning an error?

agnivade commented 9 years ago

No specific reason. I just want to conform to the standard return signatures of go functions. If there is a need to actually return an error in the future, it becomes easy.

jpillora commented 9 years ago

Ah okay, well idiomatic Go only returns an error when there is one, see http://golang.org/pkg/strings/ - I change see where it'll change much, though I guess I could be wrong

agnivade commented 9 years ago

You may be right. For now, I would just prefer to keep it as it is, unless its a big eyesore :)