search

agnivade / wasmbrowsertest

Run WASM tests inside your browser
MIT License
191 stars 22 forks source link

Flaky test TestRun/panic_fails in Windows #59

Closed agnivade closed 3 months ago

agnivade commented 6 months ago 
=== RUN   TestRun/panic_fails
=== PAUSE TestRun/panic_fails
=== RUN   TestRun/panic_in_next_run_of_event_loop_fails
=== PAUSE TestRun/panic_in_next_run_of_event_loop_fails
=== CONT  TestRun/panic_in_next_run_of_event_loop_fails
=== CONT  TestRun/panic_fails
    main_test.go:73: Unexpected error message: "exit with status 2" != "websocket url timeout reached"
=== NAME  TestRun/panic_in_next_run_of_event_loop_fails
    main_test.go:73: Unexpected error message: "context canceled" != "websocket url timeout reached"
--- FAIL: TestRun (0.00s)
    --- FAIL: TestRun/panic_fails (24.93s)
    --- FAIL: TestRun/panic_in_next_run_of_event_loop_fails (24.93s)
hajimehoshi commented 6 months ago

We have a very similar issue https://github.com/hajimehoshi/ebiten/issues/2982

hajimehoshi commented 6 months ago

https://pkg.go.dev/github.com/chromedp/chromedp#WSURLReadTimeout

Would it be possible to adjust the timeout?

agnivade commented 6 months ago

Hmm .. the default value seems 20 seconds which should be more than enough. I could increase it, but it would just push the goal post. I wonder if there's a deeper problem here.

agnivade commented 4 months ago

Re-ran tests multiple times with the associated PR. Looks like the problem is gone now.

agnivade commented 4 months ago

Well, no. It fails in master. Reopening, and skipping the test on Windows for now.

hajimehoshi commented 3 months ago

Apparently the issue was resolved. Thank you very much!

hajimehoshi commented 3 months ago

This still happens on Linux https://github.com/hajimehoshi/ebiten/actions/runs/10322461269/job/28577724123

agnivade commented 3 months ago

Go 1.19 is quite old. I am not 100% if that plays any role or not, but I only test with supported Go releases.

hajimehoshi commented 3 months ago

Sure, I'll let you know when the same thing happens with the supported Go releases...