search

agnoster / base32-js

Base32 encoding for JavaScript, based (loosely) on Crockford's Base32
https://github.com/agnoster/base32-js
MIT License
121 stars 61 forks source link

Make a bower package, and uglify with gulp. #14

Closed MichaelJCole closed 9 years ago

MichaelJCole commented 9 years ago

Hey, I wanted this as a bower.io package. Since I don't grok the code, it would be better as a PR than a fork.

Thanks BTW! Mike

Changelog: Add bower.json to make a bower.io package. Add gulp build tool to uglify into dist/base32.min.js. Add tests for minified code.

MichaelJCole commented 9 years ago

Here's how to push the package to bower.io http://bower.io/docs/creating-packages/#register

MichaelJCole commented 9 years ago

Closing to retry Travis.

MichaelJCole commented 9 years ago

The Travis error is re: gulp-load-plugins not working in Nodejs 0.8. It's an issue with the minification, so we could:

I think it depends on if you want this PR or not. Lemme know what is best and I'll fix it up!

Note: If you like, you can re-run the minification yourself by running 'npm install && gulp'.

Mike

agnoster commented 9 years ago

I say we can ignore 0.8 at this point, so I'd be up for removing that as a supported target

MichaelJCole commented 9 years ago

The light is green, the trap is clean :-)