search

agnoster / base32-js

Base32 encoding for JavaScript, based (loosely) on Crockford's Base32
https://github.com/agnoster/base32-js
MIT License
121 stars 61 forks source link

Base32 characters #4

Closed xanxys closed 11 years ago

xanxys commented 11 years ago

Is there a strong reason not to use probably most authentic RFC 4648 ( http://tools.ietf.org/html/rfc4648 ) base32 characters? (i.e. alphabet = "abcdefghijklmnopqrstuvwxyz234567")? It took me 2 hours debbuging when I was implementing some protocol requiring "base32" using this library...

xanxys commented 11 years ago

Ok, the front page says "Crockford's base32", pls ignore this issue.

agnoster commented 11 years ago

Is there something I could do to make this kind of failure more obvious? (Additionally, which alphabet to use could possibly be determined with an option?)

xanxys commented 11 years ago

Hmm, not sure. As for API, I think adding option actually hurts since it will look more complicated and people might look for other libraries (which probably you won't want).

Moving "Warning" section before "Getting Started" and adding RFC reference (not indirectly via wikipedia) to the section might help, nonetheless there will be careless unfortunate people (like me) that won't read even that.