search

agnosticful / saraka-mobile

An Android/iOS app to get used to speak phrases what you're not familiar with
0 stars 0 forks source link

Create article bloc #187

Closed ryonryon closed 5 years ago

ryonryon commented 5 years ago

@axross Can you check these change?

ryonryon commented 5 years ago

@axross I wanna write using map method like below but I couldn't can you check?

prismic_io_article_repository.dart (line 18 to 21)

- List<Article> articles = [];
- for (int i = 0; i < jsonData['results'].length; i++) {
-   articles.add(PrismicIoArticle(jsonData['results'][i]['data']));
- }
+ List<Article> articles = jsonData['results']
+      .map((at) => PrismicIoArticle(at['data']))
+      .toList();
axross commented 5 years ago

@ryotogashi Commented here: https://github.com/agnosticful/saraka-mobile/pull/187#discussion_r280252159

@axross I wanna write using map method like below but I couldn't can you check?

prismic_io_article_repository.dart (line 18 to 21)

- List<Article> articles = [];
- for (int i = 0; i < jsonData['results'].length; i++) {
-   articles.add(PrismicIoArticle(jsonData['results'][i]['data']));
- }
+ List<Article> articles = jsonData['results']
+      .map((at) => PrismicIoArticle(at['data']))
+      .toList();