Composer.json is too inclusive

agoalofalife / bpm-online

Package for working with bpm’online

8 stars 6 forks source link

Composer.json is too inclusive #1

Open diimpp opened 6 years ago

diimpp commented 6 years ago

Hi,

I've noticed, that composer requires next packages

"symfony/var-dumper": "^3.2",
"monolog/monolog": "1.*",
"slim/slim": "^3.0"

That's stuff should be in require-dev and I don't think, that slim or monolog should be required at all. It's up to library user to inject logger or choose web framework.

agoalofalife commented 6 years ago

@diimpp I agree with you, you can send PR? Hmmm ... And I do not remember that used package slim , it is necessary to revise the repository

diimpp commented 6 years ago

I can do PR, but I'm not familiar with the library as I haven't used it. So I wouldn't know what kind of issues may arise from this change.

agoalofalife commented 6 years ago

ok, I'll do it myself thank you!!