search

agocorona / MFlow

(Haskell) Web application server with stateful, type safe user interactions and widget combinators
http://mflowdemo.herokuapp.com
Other
100 stars 12 forks source link

Grid - can't remove row #47

Closed BartAdv closed 10 years ago

BartAdv commented 10 years ago

Again, Grid demo - just fire it up, remove a row and then try to submit - removed row is restored after POST.

agocorona commented 10 years ago

got it

2014-07-28 9:22 GMT+02:00 Bartosz notifications@github.com:

Again, Grid demo - just fire it up, remove a row and then try to submit

  • removed row is restored after POST.

— Reply to this email directly or view it on GitHub https://github.com/agocorona/MFlow/issues/47.

Alberto.

agocorona commented 10 years ago

I found the error. I substituted time ago manOf by allOf in wEditList, because manyOf filter out not only the deleted widgets, but also the widgets with validation errors. But allOf expect all the created widgets to return results, including the deleted ones. If not, it fails silently and that´s the reason because the page appears again with all the created widgets.

I´m changing manyOf to return error if some widget return an error. But that´s not simple.

2014-07-28 10:37 GMT+02:00 Alberto G. Corona agocorona@gmail.com:

got it

2014-07-28 9:22 GMT+02:00 Bartosz notifications@github.com:

Again, Grid demo - just fire it up, remove a row and then try to submit

  • removed row is restored after POST.

— Reply to this email directly or view it on GitHub https://github.com/agocorona/MFlow/issues/47.

Alberto.

Alberto.

BartAdv commented 10 years ago

Well, I hope you succeed, good luck:)

On Tue, Jul 29, 2014 at 12:10 PM, agocorona notifications@github.com wrote:

I found the error. I substituted time ago manOf by allOf in wEditList, because manyOf filter out not only the deleted widgets, but also the widgets with validation errors. But allOf expect all the created widgets to return results, including the deleted ones. If not, it fails silently and that´s the reason because the page appears again with all the created widgets.

I´m changing manyOf to return error if some widget return an error. But that´s not simple.

2014-07-28 10:37 GMT+02:00 Alberto G. Corona agocorona@gmail.com:

got it

2014-07-28 9:22 GMT+02:00 Bartosz notifications@github.com:

Again, Grid demo - just fire it up, remove a row and then try to submit

  • removed row is restored after POST.

— Reply to this email directly or view it on GitHub https://github.com/agocorona/MFlow/issues/47.

Alberto.

Alberto.

— Reply to this email directly or view it on GitHub https://github.com/agocorona/MFlow/issues/47#issuecomment-50458088.

BartAdv commented 10 years ago

So...what version is on heroku at the moment? Cause the error is not visible there, and also #48 doesn't seem to occur there.

agocorona commented 10 years ago

I think that I uploaded it to the git repository. I can not check it now El 04/08/2014 10:24, "Bartosz" notifications@github.com escribió:

So...what version is on heroku at the moment? Cause the error is not visible there, and also #48 https://github.com/agocorona/MFlow/issues/48 doesn't seem to occur there.

— Reply to this email directly or view it on GitHub https://github.com/agocorona/MFlow/issues/47#issuecomment-51029699.

agocorona commented 10 years ago

I uploaded my last changes to github so this is fixed. However there is an small bug assiciated with this: since the added wigets are cached, they do not report valiation errors. they simply fail and the page is presented again without error messages.

BartAdv commented 10 years ago

Hm, somehow I haven't been able to spot this issue, but I must say I've got some pleasant experience out of this again (been able to also use it to solve similar scenario to #49).