agoda-com / Kakao

This repo is no longer supported. Please visit a https://github.com/KakaoCup/Kakao
Apache License 2.0
1.11k stars 102 forks source link

Add KSwitch to allow swipe gestures on switches #171

Closed sebastienrouif closed 4 years ago

sebastienrouif commented 4 years ago

addresses #168 I was not sure how you wanted to handle @RequiresApi(Build.VERSION_CODES.JELLY_BEAN) nor if more documentation files were needed The TestActivityScreen needs big screen to run now, should it be made a ScrollView ?

sebastienrouif commented 4 years ago

kakao

Vacxe commented 4 years ago

@sebastienrouif also don't forget to apply code style.

@Unlimity what do u think about swipe action? I think that it can create flakiness factor, and also you can obtain same result with click

I agree with adding KSwitch

Unlimity commented 4 years ago

@Vacxe although it can introduce the flakiness to the execution of the tests, if there is a specific requirement to emulate user's gestures while interacting with switch, I suppose we can provide that functionality. And yes, you can basically replicate it with click. Although each click will change the checked state, while swipes in the single direction should change the state only first time. @sebastienrouif could you please resolve the conflicts?

Vacxe commented 4 years ago

@sebastienrouif please solve all conflicts and review fixes and after that put Ready to merge label on your PR when you be sure that all UI test is passed locally

Close: #168

Cheers!

sebastienrouif commented 4 years ago

changes :

Vacxe commented 4 years ago

@sebastienrouif Thanks for the contribution!