search

agoda-com / Kakao

This repo is no longer supported. Please visit a https://github.com/KakaoCup/Kakao
Apache License 2.0
1.11k stars 102 forks source link

feat: Add KSpinner (issue #118) #182

Closed michaelbukachi closed 4 years ago

michaelbukachi commented 4 years ago

This pull request adds Kspinner as discussed in issue #118 and pull request #119. @Unlimity do you mind reviewing the code. I still want to add more assertions such as isOpened(), isClosed()

CLAassistant commented 4 years ago

CLA assistant check
All committers have signed the CLA.

Unlimity commented 4 years ago

Hi! Thanks for contribution. Right now I'm in a middle of a trip with limited time and access to laptop and will be able to review your PR next week only. Sorry for inconvenience.

michaelbukachi commented 4 years ago

It's alright. No problem.

Vacxe commented 4 years ago

@michaelbukachi @Unlimity I will try to review it today evening

bvdaakster commented 4 years ago

Would appreciate to have this merged as well

Vacxe commented 4 years ago

@michaelbukachi you can easily add new lines, to your code. Just check script in contribution policy. Also don't forget to apply code style to this part of the code.

Vacxe commented 4 years ago

@michaelbukachi Please polish the code and we can merge it.

Cheers!

michaelbukachi commented 4 years ago

@Vacxe I've corrected the newlines issue

Vacxe commented 4 years ago

@michaelbukachi that's great, but could you also fix all comments placed by @Unlimity and me?

Vacxe commented 4 years ago

Thanks for your contribution!

Vacxe commented 4 years ago

Close: #118

Vacxe commented 4 years ago

@michaelbukachi will merge it in the evening today. Cheers.