search

agoda-com / Kakao

This repo is no longer supported. Please visit a https://github.com/KakaoCup/Kakao
Apache License 2.0
1.11k stars 102 forks source link

Support GridLayout #183

Closed lucas34 closed 4 years ago

lucas34 commented 4 years ago

I'm changing one component from RecyclerView to GridLayout. This critical component have lot of UI Test using kakao. However I don't see the equivalent of GridLayout for Kakao.

Vacxe commented 4 years ago

That's really strange. Cause view matching doesn't related on layout adapters.

Could you provide more information please?

dannysunyu commented 4 years ago

@Vacxe I think he meant how to interact with GridLayout, does Kakao have a KGridLayout kind of support.

Vacxe commented 4 years ago

@dannysuen Just I don't understand purposes for that. Interaction with GridLayout will be the same as LinearLayout and etc.

Or you wanna do the check in specific row and collum?

lucas34 commented 4 years ago

Yes correct, the behaviour now is quite similar as anything extending ViewGroup. However I'm not very familiar with KaKao. And after removing the recycler view I don't understand how I can actually check the number of Childs (For example) on my layout.

Vacxe commented 4 years ago

@lucas34 I'll look around for the investigation

timkabot commented 3 years ago

@lucas34 did you succeed?

lucas34 commented 3 years ago

Yes we have our own implementation of KGridLayout

Elvina-G commented 3 years ago

Yes we have our own implementation of KGridLayout how did you write your KGridLayout?

Vacxe commented 3 years ago

@lucas34 u always able to create a PR