search

agoda-com / Kakao

This repo is no longer supported. Please visit a https://github.com/KakaoCup/Kakao
Apache License 2.0
1.11k stars 102 forks source link

Made IndexMatcher reusable #200

Closed yapkolotilov closed 4 years ago

yapkolotilov commented 4 years ago

Read issue for details

claassistantio commented 4 years ago

CLA assistant check
All committers have signed the CLA.

Unlimity commented 4 years ago

Close: #199

yapkolotilov commented 4 years ago

Sorry, guys, I'm not familiar with GitHub pull request workflow. In com.agoda.kakao.common.builders.ViewBuilder just paste this above withIndex:

     /**
     * Matches only view at given [index], if there are multiple views that matches
     *
     * @param index Index of the view to match
     * @param function [ViewBuilder] that will result in matcher
     */
Unlimity commented 4 years ago

You can just make the change and push it to your branch

Unlimity commented 4 years ago

No worries, updated it for you 👍

Vacxe commented 4 years ago

@yapkolotilov thanks for the contribution mate!

Vacxe commented 4 years ago

@yapkolotilov also please sign the CLA. Just tap here under licence/cla task.