search

agoda-com / Kakao

This repo is no longer supported. Please visit a https://github.com/KakaoCup/Kakao
Apache License 2.0
1.11k stars 102 forks source link

Add Fit XY for test cases #235

Closed lucas34 closed 3 years ago

Vacxe commented 4 years ago

@lucas34 API 25 works as expected. Crashed on 28

Expected: with drawable id 2131165292 or provided instance
Got: "AppCompatImageView{id=2131230864, res-name=imgView, visibility=VISIBLE, width=1080, height=63, has-focus=false, has-focusable=false, has-window-focus=true, is-clickable=false, is-enabled=true, is-focused=false, is-focusable=false, is-layout-requested=false, is-selected=false, layout-params=android.widget.FrameLayout$LayoutParams@1154caf, tag=null, root-is-layout-requested=false, has-input-connection=false, x=0.0, y=0.0}"
lucas34 commented 4 years ago

Ok that weird. From the code I don't see any specific code related to API level. Any idea what is causing this issue ?

Vacxe commented 4 years ago

@lucas34 from API 28 .getDrawable() from ImageView return not the same image as original one

Vacxe commented 3 years ago

@lucas34 even with force pushed changes it fails on API 28 +

lucas34 commented 3 years ago

Yes I. was trying some solution. I saw that Fresco lib has an implementation of Scaled drawable to scale an underlaying drawable to a specific fit param.