search

agoda-com / Kakao

This repo is no longer supported. Please visit a https://github.com/KakaoCup/Kakao
Apache License 2.0
1.11k stars 102 forks source link

Upgrade Espresso version to 3.3.0 #238

Closed phansier closed 3 years ago

phansier commented 3 years ago

Steps to reproduce:

I have struggled with binary incompatibility of Espresso's RecyclerViewActions because of version in Kakao (3.1.1) used less then in Kaspresso library and in my project (3.3.0).

I'm going to suggest a pull request with upgraded version.

Observed Results:

During test execution:

java.lang.NoClassDefFoundError: Failed resolution of: Landroidx/test/espresso/contrib/RecyclerViewActions;
at com.agoda.kakao.recycler.RecyclerActions$DefaultImpls.scrollTo(RecyclerActions.kt:49)
at com.agoda.kakao.recycler.KRecyclerView.scrollTo(KRecyclerView.kt:31)

Expected Results:

Avoiding versions conflict.

Relevant Code:

  KRecyclerView.scrollTo(recyclerItem)
Unlimity commented 3 years ago

Hello and thanks for contribution! If upgrading espresso version breaks it's behavior I suggest to resolve the issue in your PR or wait until we will have time to upgrade and fix the issue. Cheers!

phansier commented 3 years ago

@Unlimity Please have a look at #239 PR Or I didn't catch which one issue in the PR should I resolve for it was accepted?

Unlimity commented 3 years ago

@AndreySBer 

java.lang.NoClassDefFoundError: Failed resolution of: Landroidx/test/espresso/contrib/RecyclerViewActions;
at com.agoda.kakao.recycler.RecyclerActions$DefaultImpls.scrollTo(RecyclerActions.kt:49)
at com.agoda.kakao.recycler.KRecyclerView.scrollTo(KRecyclerView.kt:31)

I thought this exception is risen when update is introduced. Did you mean that the version update solves this issue for you?

Unlimity commented 3 years ago

PR is merged. Everything seems fine. Thanks!