search

agoda-com / kafka-jdbc-connector

Simple way to copy data from relational databases into kafka.
https://github.com/agoda-com/kafka-jdbc-connector/wiki
Apache License 2.0
20 stars 8 forks source link

increase code coverage of DataConverter #15

Closed arpanchaudhury closed 7 years ago

arpanchaudhury commented 7 years ago

Ref https://github.com/agoda-com/kafka-jdbc-connector/issues/12

CLAassistant commented 7 years ago

CLA assistant check
All committers have signed the CLA.

codecov-io commented 7 years ago

Codecov Report

Merging #15 into master will increase coverage by 15.77%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #15       +/-   ##
===========================================
+ Coverage   26.18%   41.95%   +15.77%     
===========================================
  Files           9        9               
  Lines         317      317               
  Branches       23       25        +2     
===========================================
+ Hits           83      133       +50     
+ Misses        234      184       -50
Impacted Files Coverage Δ
...oda/kafka/connector/jdbc/utils/DataConverter.scala 100% <100%> (+64.1%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b3649d6...7fc89b6. Read the comment docs.