search

agoda-com / kafka-jdbc-connector

Simple way to copy data from relational databases into kafka.
https://github.com/agoda-com/kafka-jdbc-connector/wiki
Apache License 2.0
20 stars 8 forks source link

adding test for DataServices #16

Closed arpanchaudhury closed 7 years ago

arpanchaudhury commented 7 years ago

Ref https://github.com/agoda-com/kafka-jdbc-connector/issues/12

codecov-io commented 7 years ago

Codecov Report

Merging #16 into master will increase coverage by 26.71%. The diff coverage is 82.6%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #16       +/-   ##
===========================================
+ Coverage   41.95%   68.67%   +26.71%     
===========================================
  Files           9        9               
  Lines         317      316        -1     
  Branches       25       40       +15     
===========================================
+ Hits          133      217       +84     
+ Misses        184       99       -85
Impacted Files Coverage Δ
...oda/kafka/connector/jdbc/utils/DataConverter.scala 100% <ø> (ø) :arrow_up:
...om/agoda/kafka/connector/jdbc/JdbcSourceTask.scala 0% <0%> (ø) :arrow_up:
...da/kafka/connector/jdbc/services/DataService.scala 100% <100%> (+100%) :arrow_up:
...nnector/jdbc/services/TimeIdBasedDataService.scala 78.94% <100%> (+78.94%) :arrow_up:
...a/connector/jdbc/services/IdBasedDataService.scala 77.41% <100%> (+77.41%) :arrow_up:
...connector/jdbc/services/TimeBasedDataService.scala 88.46% <100%> (+88.46%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3ddbfc9...f9b9620. Read the comment docs.