search

agoda-com / kafka-jdbc-connector

Simple way to copy data from relational databases into kafka.
https://github.com/agoda-com/kafka-jdbc-connector/wiki
Apache License 2.0
20 stars 8 forks source link

adding more tests for JdbcSourceConnectorConfig #18

Closed arpanchaudhury closed 7 years ago

arpanchaudhury commented 7 years ago

Ref https://github.com/agoda-com/kafka-jdbc-connector/issues/12

codecov[bot] commented 7 years ago

Codecov Report

Merging #18 into master will increase coverage by 4.55%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
+ Coverage   71.91%   76.47%   +4.55%     
==========================================
  Files           9        9              
  Lines         324      323       -1     
  Branches       26       28       +2     
==========================================
+ Hits          233      247      +14     
+ Misses         91       76      -15
Impacted Files Coverage Δ
...fka/connector/jdbc/JdbcSourceConnectorConfig.scala 100% <100%> (+30.61%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fcada12...230561f. Read the comment docs.