agoldis / webpack-require-from

Webpack plugin that allows to configure path or URL for fetching dynamic imports
MIT License
192 stars 31 forks source link

Bump tapable to ^1 + ^2 #73

Closed pavelloz closed 3 years ago

pavelloz commented 3 years ago

Hi!

Great job on the plugin, we at @Platform-OS use it for over 3 years and its been a real life saver.

Recently im struggling with keeping my dependencies a lot because it seems like some webpack plugins are requiring tapable ^2 and webpack-require-from is requiring ^1, so there is a conflict (see log at the end).

Would it be possible to bump version of tapable to ^2? Or if there are some breaking changes and you dont have time, will you accept PR if i learn how to do it?

Best, Pawel

npm install npm ERR! code ERESOLVE npm ERR! ERESOLVE unable to resolve dependency tree npm ERR! npm ERR! Found: tapable@2.2.0 npm ERR! node_modules/tapable npm ERR! dev tapable@"^2.2.0" from the root project npm ERR! tapable@"^2.2.0" from enhanced-resolve@5.8.2 npm ERR! node_modules/enhanced-resolve npm ERR! enhanced-resolve@"^5.8.0" from webpack@5.39.1 npm ERR! node_modules/webpack npm ERR! dev webpack@"^5.39.1" from the root project npm ERR! 7 more (@webpack-cli/configtest, css-loader, esbuild-loader, ...) npm ERR! 2 more (esbuild-loader, webpack) npm ERR! npm ERR! Could not resolve dependency: npm ERR! peer tapable@"^1.0.0" from webpack-require-from@1.8.5 npm ERR! node_modules/webpack-require-from npm ERR! dev webpack-require-from@"^1.8.5" from the root project npm ERR! npm ERR! Fix the upstream dependency conflict, or retry npm ERR! this command with --force, or --legacy-peer-deps npm ERR! to accept an incorrect (and potentially broken) dependency resolution. npm ERR! npm ERR! See /Users/pavel/.npm/eresolve-report.txt for a full report. npm ERR! A complete log of this run can be found in: npm ERR! /Users/pavel/.npm/_logs/2021-06-21T09_44_41_057Z-debug.log
pavelloz commented 3 years ago

I just tested and it looks like bumping to ^2 does not break anything.

diff --git a/package.json b/package.json
index f16d16a..9ae2dda 100644
--- a/package.json
+++ b/package.json
@@ -31,6 +31,6 @@
     "memfs": "^3.2.0",
     "memory-fs": "^0.4.1",
     "mocha": "^5.2.0",
-    "tapable": "^1.0.0"
+    "tapable": "^2.2.0"
   }
 }