search

agolo / logstash-test-runner

Logstash configuration testing framework
https://blog.agolo.com/the-easy-way-to-test-your-logstash-configuration-3f80eb5ffd59
MIT License
103 stars 24 forks source link

Setup only works with nodejs 8 #6

Closed CayoM closed 6 years ago

CayoM commented 6 years ago

when installing the default nodejs version (v4.2.6) from ubuntu 16.04 packages, i was getting this error:

  propertyFilter: name => !program.ignoreProps.includes(name)
                                               ^

TypeError: program.ignoreProps.includes is not a function
    at program.version.usage.option.val.option.program.compareFiles.map.fs.readFileSync.split.map.require.create.propertyFilter.name (/etc/docker/compose-files/logstash-test-runner/log-diff.js:36:48)
    at objectsDiffFilter (/etc/docker/compose-files/logstash-test-runner/node_modules/jsondiffpatch/src/filters/nested.js:37:28)
    at Pipe.process (/etc/docker/compose-files/logstash-test-runner/node_modules/jsondiffpatch/src/pipe.js:18:5)
    at Processor.process (/etc/docker/compose-files/logstash-test-runner/node_modules/jsondiffpatch/src/processor.js:46:14)
    at DiffPatcher.diff (/etc/docker/compose-files/logstash-test-runner/node_modules/jsondiffpatch/src/diffpatcher.js:48:25)
    at Object.<anonymous> (/etc/docker/compose-files/logstash-test-runner/log-diff.js:42:29)
    at Module._compile (module.js:410:26)
    at Object.Module._extensions..js (module.js:417:10)
    at Module.load (module.js:344:32)
    at Function.Module._load (module.js:301:12)

with nodejs v8.12.0 its working without issues.

Can you point the Version on README.md, so maybe other people wont have to deal with this error.

agolomoodysaada commented 6 years ago

https://github.com/agolo/logstash-test-runner/commit/35343b61cb3107ccdf0e5f3cf30d96d92beb08c4 closes this Thank you!