search

agoodshort / telescope-git-submodules.nvim

Telescope extension for git submodules
MIT License
16 stars 2 forks source link

fix DiffviewOpen error with white spaces in path #8

Closed donalffons closed 3 months ago

donalffons commented 6 months ago

Thanks for your work on this plugin. I noticed that the "Diffview" part of this plugin didn't work with one of my repos and tried to identify the root cause. Apparently, white spaces in the path to the repo break the call to DiffviewOpen. Here is my attempt at fixing this.

agoodshort commented 4 months ago

Thanks for the PR and flagging this issue. I installed your branch and tried to reproduce your scenario but I still faced some issues. I force-pushed a little something on your commit that fixes some issues I had with the repo_name.

Please give that a go, and if that works for you too I will merge this.

Here are the steps I followed to reproduce your issue:

mkdir test
cd test
git init
touch README.md
git submodule add https://github.com/agoodshort/white-space "white space"