search

agora-inc / platform

Full code for mora.stream, the "Twitch.tv for academic researchers". The streaming platform served several thousands of concurrent viewers. This has now been acquired and absorbed by Cassyni.
https://cassyni.com/mora
4 stars 0 forks source link

Social media buttons not working #411

Closed AlainRossier closed 2 years ago

AlainRossier commented 3 years ago

The 'Share' buttons at these 3 locations does not work. Expected behaviour: social media icons appear on the right-hand side of the page

Screenshot from 2021-09-01 11-21-59 (Where to find this: when clicking on a talk in www.mora.stream/browse; name of the Component: talkCard.tsx) Screenshot from 2021-09-01 11-22-35 (Where to find this: after clicking on enter on a talk in www.mora.stream/browse; name of the View: talkSharingPage.tsx) Screenshot from 2021-09-01 11-22-44 (Where to find this: when visiting an agora, e.g.: www.mora.stream/datasig; name of the View: ChannelPage.tsx and ManageChannelPage.tsx)

ckhackshaw commented 2 years ago

I am going to mark this as complete. I am not sure if I missed anything but this feature actually works, I have attached screenshots of all three pages.

Something to note, the email icon opens the link in the same tab. That might be something we would need to change.

Screenshot 2021-10-23 at 10 21 32 PM Screenshot 2021-10-23 at 10 17 36 PM Screenshot 2021-10-23 at 10 20 38 PM
RemyMess commented 2 years ago

it works visibly. this has been somehow fixed