Closed casey closed 2 years ago
@soenkehahn This is a gargantuan PR, so I wanted to get it up. I'll probably keep working on it, and start moving the slow tests and browser tests.
The bugfix_symlink_with_relative_base_directory is failing on windows. Here's the log. I gave up on it for now because this is a massive PR already, and porting tests one by one from here on out seems like a better idea.
This refactors the integration tests:
AgoraTestContext::builder()
creates a builder, which can then be customized with more method calls, and finallybuilde()
constructs the test context. This should allow all customization to happen via the builder, which I find much easier to reason about vs the multiple nesting test functions we have currentlyAgoraTestContext
, which allowed simplifying a bunch of tests quite a bittests/integration.rs
, which now use the builder pattern