search

agora-org / agora

File server that accepts Lightning Network payments for downloads
Creative Commons Zero v1.0 Universal
184 stars 26 forks source link

Statically link release binaries #283

Closed terror closed 2 years ago

terror commented 2 years ago

This PR uncurses #269, we believe that there is something wrong with the cache.

casey commented 2 years ago

We gave up on on statically linking arm builds. x86 Ubuntu doesn't include an ARM + musl linker, so we would have had to use cargo cross or install the toolchain ourselves. cargo cross gave us weird errors, so we gave up on that. We could install a arm musl cross compilation toolchain (which would include a linker) ourselves, probably from https://musl.cc. But, we figured that we would much of the benefit of static linking just from doing it on Mac, Linux, and Windows, so that's what this PR does.

casey commented 2 years ago

Pushed a tag.

casey commented 2 years ago

Pushed another tag, which built, so LGTM.

@soenkehahn I'm inclined to merge this. It statically links more binaries, and arm is tricky, so not doing it for now seems like a good idea.