search

agora-org / agora

File server that accepts Lightning Network payments for downloads
Creative Commons Zero v1.0 Universal
185 stars 24 forks source link

Update proc-macro2 to 1.0.33, allow to run tests with cranelift #286

Closed soenkehahn closed 2 years ago

soenkehahn commented 2 years ago

This PR allows to run the agora test-suite with cranelift. See https://github.com/bjorn3/rustc_codegen_cranelift/issues/1101.

One obvious advantage of cranelift is that compilation is faster, and one obvious downside is that executing the tests is slower. There may be other implications. So I'm not sure whether running the tests with cranelift is actually a good idea. In any case updating the proc-macro2 version shouldn't hurt, and it allows us to experiment with cranelift.

See also https://github.com/bjorn3/rustc_codegen_cranelift#readme for a description on how to set up cranelift.

casey commented 2 years ago

Sweet! How did you do the selective version bump? I noticed that Cargo.lock changed without Cargo.toml changing, and I don't think I know how to do that for a single dependency.

soenkehahn commented 2 years ago

Sweet! How did you do the selective version bump? I noticed that Cargo.lock changed without Cargo.toml changing, and I don't think I know how to do that for a single dependency.

cargo update -p proc-macro2:1.0.30, where 1.0.30 is the old version, e.g. the version that you want to update.