search

agora-org / agora

File server that accepts Lightning Network payments for downloads
Creative Commons Zero v1.0 Universal
184 stars 26 forks source link

Move Config type into submodule of vfs #287

Closed neunenak closed 2 years ago

neunenak commented 2 years ago

With the new VFS system, the Config type is now effectively an implementation detail of the VFS, and can exist as a non-public submodule of the vfs module.

neunenak commented 2 years ago

@casey @soenkehahn this is something I noticed can be done now that the VFS code is merged. I'm not sure if there's a case for leaving Config as a type that should be available throughout the codebase.

casey commented 2 years ago

This looks good to me. Is it possible to keep the vfs module in vfs.rs instead of mod.rs, or is it necessary to have submodules?

neunenak commented 2 years ago

This looks good to me. Is it possible to keep the vfs module in vfs.rs instead of mod.rs, or is it necessary to have submodules?

Just tried it and apparently that works, you can have vfs.rs and vfs/config.rs and the module hierarchy works out as expected.

casey commented 2 years ago

Sweet, LGTM

For some reason the tests are super flaky, and I had to rerun them a bunch to get them to pass.