search

agoragames / bnet_scraper

A Nokogiri-based scraper of Battle.net profiles. Currently this only includes Starcraft2.
MIT License
22 stars 7 forks source link

Adds support for non-American date formats #19

Closed cadwallion closed 11 years ago

cadwallion commented 11 years ago

The domain us.battle.net uses mm/dd/yyyy format, everywhere else uses dd/mm/yyyy format. This moves the date conversion from Achievement to AchievementScraper to add logic for region detection.

This is currently lacking a VCR cassette for the new spec because EU battle.net is down. Once it's back up and I can store the cassette to pass the broken test, it will be ready. Fixes #17 .

cadwallion commented 11 years ago

Build is green, merging for great justice.