[NEED TO DISCUSS] Adds support for RabbitMQ consumer_cancel_notify - Githubissues

agoragames / haigha

AMQP Python client

BSD 3-Clause "New" or "Revised" License

161 stars 41 forks source link

[NEED TO DISCUSS] Adds support for RabbitMQ consumer_cancel_notify #79

Closed vitaly-krugl closed 9 years ago

vitaly-krugl commented 9 years ago

Hi @awestendorf, it's me again. This PR implements support for RabbitMQ's consumer_cancel_notify feature described in www.rabbitmq.com/consumer-cancel.html. This is a very useful feature that we rely on that prevents consumers from hanging indefinitely when the consumed queue is deleted, for example.

I am sharing this PR with you early, because I need a tiny bit of help from you with one quick question about coding choices that depend on your preferences. I will enter my question as a comment in this PR in rabbit_connection.py near the relevant code.

This PR doesn't have tests yet, so it's not ready for merging.

vitaly-krugl commented 9 years ago

Thanks, @awestendorf. I will close this for now until I am ready with the tests.