agoragames / leaderboard

Leaderboards backed by Redis in Ruby
https://rubygems.org/gems/leaderboard
MIT License
480 stars 65 forks source link

Add leader_at and leader_at_in methods #14

Closed jgadbois closed 12 years ago

jgadbois commented 12 years ago

Added these methods to make it easer to get the leader at a given rank

czarneckid commented 12 years ago

Can you add similar tests to the reverse_leaderboard_spec.rb? Thanks.

jgadbois commented 12 years ago

Updated per your requests

jgadbois commented 12 years ago

Done

czarneckid commented 12 years ago

I'm thinking I might change the method names to member_at and member_at_in. Same thing for #15 in changing leaders_from_score_range and leaders_from_score_range_in to members_from_score_range and members_from_score_range_in.

Thoughts?

jgadbois commented 12 years ago

I think member might make more sense too.

jgadbois commented 12 years ago

Just saw you already made the change - looks good! Thanks for pulling this in.

czarneckid commented 12 years ago

No problem. Thanks again for the contribution.