search

agoragames / leaderboard

Leaderboards backed by Redis in Ruby
https://rubygems.org/gems/leaderboard
MIT License
478 stars 65 forks source link

Fix for #60 #61

Closed dcampano closed 7 years ago

dcampano commented 7 years ago

This is a fix for #60. The code wasn't using the filtered members list when setting include_missing to false.

czarneckid commented 7 years ago

Thanks. I'll take a look at this PR/issue this week.

czarneckid commented 7 years ago

I cherry-picked the first 2 commits here for the fix for #60. I didn't end up taking the optimize around_me commit since there were failing tests. I'll take a look at that today outside of this PR.

dcampano commented 7 years ago

Oops, yeah, the optimized around_me wasn't supposed to be part of the pull request. I must have accidentally pushed that. Sorry about that. When I benchmarked that change, it reduced the around_me times by 50%. However, I didn't do the work yet to make it work for the Tie leaderboard and Challenge leaderboard.