search

agoragames / leaderboard

Leaderboards backed by Redis in Ruby
https://rubygems.org/gems/leaderboard
MIT License
478 stars 65 forks source link

Returns last page leader even when offset is way beyond it #65

Closed abhiQmar closed 7 years ago

abhiQmar commented 7 years ago

Shouldn't it return an empty list when current_page > total_pages. https://github.com/agoragames/leaderboard/blob/master/lib/leaderboard.rb#L713-L715

czarneckid commented 7 years ago

If you request a page before the first page, it gives you the first page. This is similar behavior. If you request a page after the last page, it gives you the last page.