agorapulse / grails-facebook-sdk

Facebook SDK Grails Plugin
http://agorapulse.github.com/grails-facebook-sdk/guide
30 stars 13 forks source link

Wrong callback reference in login-link.js #26

Closed mfmpittau closed 11 years ago

mfmpittau commented 11 years ago

The typeof refers to fn instead of callback:

  if (typeof fn === 'function') {
      callback(response);
  }

It would be nice to get back in the callback, also the element that triggered the event

  if (typeof callback === 'function') {
      callback(response, event.target);
  }
benorama commented 11 years ago

Indeed, I've incorporated your change. It will be able in 0.4.7 released next week.

Thanks!