search

agorapulse / grails-sentry

A Sentry client for Grails
Apache License 2.0
12 stars 16 forks source link

Plugins does not seem to work in Grails 3.3.0 anymore #40

Open goedef opened 7 years ago

goedef commented 7 years ago

I am using the Sentry plugin for all my applications. I am upgrading to grails 3.3.0 and I cannot get the plugin working anymore. I can send messages from the client, but the logback appender does not report issues anymore. Is the plugin available for grails 3.3.0?

musketyr commented 7 years ago

Are you using the latest version? There were some problems with previous releases. No-one haven't tested this plugin with 3.3.0. I will do so o Monday.

goedef commented 7 years ago

Hi Vladimir,

Yes I am using the latest version 11.4.0.2

I am testing the plugin right now with grails 3.3.0. I asume there is something different with te autowiring.

Fred

Van: Vladimir Orany notifications@github.com Beantwoorden - Aan: agorapulse/grails-sentry reply@reply.github.com Datum: zaterdag 2 september 2017 10:14 Aan: agorapulse/grails-sentry grails-sentry@noreply.github.com CC: Fred de Goede fred@degoede.nu, Author author@noreply.github.com Onderwerp: Re: [agorapulse/grails-sentry] Plugins does not seem to work in Grails 3.3.0 anymore (#40)

Are you using the latest version? There were some problems with previous releases. No-one haven't tested this plugin with 3.3.0. I will do so o Monday.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/agorapulse/grails-sentry/issues/40#issuecomment-326729908, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAwSsp3kbHZtMgDr6FsWGcXTyQ2dxHCkks5seQ5IgaJpZM4PK1Cp.

goedef commented 7 years ago

After extensive testing I found a temporary working solution for my application.

It seems the plugin does not append sentry to the ROOT logger. I defined another logger in logback.groovy (where 'prestotype' is the app name): logger 'prestotype', INFO, ['STDOUT','WEBAPP'], false

and added in my application.yml file: grails.plugin.sentry.active: true grails.plugin.sentry.dsn: 'http://--:--@sentry.host.nl/11' grails.plugin.sentry.levels: ['ERROR'] grails.plugin.sentry. loggers: ['prestotype','grails.app']

Now the plugin reports errors AND warnings. I cannot influence the log level.

musketyr commented 7 years ago

I'm sorry, I can't replicate myself. I've upgraded Grails to 3.3.0 on https://github.com/agorapulse/grails-sentry/tree/feature/grails-3-3-0 branch but everything works as expected on a first sight.

Are you able to debug after following line?

https://github.com/agorapulse/grails-sentry/blob/a1ea11fcd311c1bbdb26eb8611274ce242f34fb4/src/main/groovy/grails/plugin/sentry/SentryGrailsPlugin.groovy#L108