[124036] Update kinesis lib to not overide consumerFilterKey

agorapulse / micronaut-aws-sdk

Agorapulse AWS SDK

36 stars 14 forks source link

[124036] Update kinesis lib to not overide consumerFilterKey #215

Closed Irteza-S closed 3 months ago

Irteza-S commented 3 months ago

Context : in the library used to push event in kinesis stream, the method putEvent overrides the consumerFilterKey. We don't want this method to overide the consumerFilterKey. What we want is to set the consumerFilterKey only if the event has not already a consumerFilterKey This will allow to listen events in local that come from beta kinesis

Dev :

check if event has alreadyConsumerfilterkey set, if not then set it

Irteza-S commented 3 months ago

@musketyr no woories I just opened the PR, was waiting for the release :p

musketyr commented 3 months ago

well, this one is for the Micronaut 4.x anyway. do you think you would be able to cherry pick the change into https://github.com/agorapulse/micronaut-aws-sdk/tree/2.x as well?