search

agoric-labs / PlaygroundVat

OBSOLETE prototype Vat host: use SwingSet instead
Apache License 2.0
30 stars 5 forks source link

ESLint changes to test/test-marshal.js #35

Closed katelynsills closed 5 years ago

katelynsills commented 5 years ago

Errors

screen shot 2019-02-21 at 10 48 22 am

Fixes

  1. Remove unused imports
  2. Consolidate multiple imports of host
  3. Deal with undefined vars/arguments
  4. Disable eslint on the intended require of @agoric/harden

Remaining Issues that Need Discussion

We have a shadowing of hash58. Which do we want to use? We have one imported from host and one from makeVatEndowments.

warner commented 5 years ago

actually hold off on this one a few hours, I've got some cleanup patches in the works that should reduce the need for some of it

warner commented 5 years ago

go ahead and land this one, mark and I need to discuss the cleanup I was doing before we agree to apply my changes.