agoric-labs / PlaygroundVat

OBSOLETE prototype Vat host: use SwingSet instead
Apache License 2.0
30 stars 5 forks source link

ESLint changes for src/flow/flowcomm.js #55

Closed katelynsills closed 5 years ago

katelynsills commented 5 years ago

Errors

screen shot 2019-02-21 at 6 03 51 pm

Fixes

  1. disable eslint rule no-use-before-define for this file. Vows, Flows, InnerVows, etc all reference each other. I was thinking we can revisit this when we split this file up. Thoughts?
  2. allow import of harden
  3. remove scheduleHack, which I couldn't find a use of anywhere in PlaygroundVat
  4. change ++ and-- to their longer equivalents
  5. change function debugID to getDebugID so that the variable debugID can be defined
  6. ESLint believes that the parameters of catch are not scoped to catch, so rename reason to reason2
  7. for..of to forEach when iterating over arrays (map would be faster, but would also have an eslint error)
  8. change unnamed functions to arrow style
  9. allow intentionally unused args
  10. Disable class-methods-use-this when the method intentionally does not use this.
  11. Allow if (0) where indicated as a hack

Remaining Issues that Need Discussion

screen shot 2019-02-21 at 7 43 35 pm